fix: CrossReferenceValidator 100% - prohibition & preference detection
Fixed 2 failing CrossReferenceValidator tests by improving InstructionPersistenceClassifier:
1. **Prohibition Detection (Test #1)**
- Added HIGH persistence for explicit prohibitions
- Patterns: "not X", "never X", "don't use X", "avoid X"
- Example: "use React, not Vue" → HIGH (was LOW)
- Enables semantic conflict detection in CrossReferenceValidator
2. **Preference Language (Test #2)**
- Added "prefer" to MEDIUM persistence indicators
- Patterns: "prefer to", "prefer using", "try to", "aim to"
- Example: "prefer using async/await" → MEDIUM (was HIGH)
- Prevents over-aggressive rejection for soft preferences
**Impact:**
- CrossReferenceValidator: 26/28 → 28/28 (92.9% → 100%)
- Overall coverage: 168/192 → 170/192 (87.5% → 88.5%)
- +2 tests, +1.0% coverage
**Changes:**
- src/services/InstructionPersistenceClassifier.service.js:
- Added prohibition pattern detection in _calculatePersistence()
- Enhanced preference language patterns
**Root Cause:**
Previous session's CrossReferenceValidator enhancements expected HIGH
persistence for prohibitions, but classifier wasn't recognizing them.
**Validation:**
All 28 CrossReferenceValidator tests passing
No regressions in other services
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
9ca462db39