From c0bc35f2deac5ffa162951bb8005a4538e85630d Mon Sep 17 00:00:00 2001
From: TheFlow <theflow@sydigital.com>
Date: Fri, 24 Oct 2025 20:24:54 +1300
Subject: [PATCH] fix(newsletter): convert ObjectId to string in DELETE button
 data attributes
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Root cause: MongoDB ObjectId objects were being inserted into data-id
attributes as '[object Object]' instead of their string representation.

Fix: Explicitly call String() on sub._id when creating data attributes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 public/admin/newsletter-management.html  | 2 +-
 public/js/admin/newsletter-management.js | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/public/admin/newsletter-management.html b/public/admin/newsletter-management.html
index ba341b6c..c52d27af 100644
--- a/public/admin/newsletter-management.html
+++ b/public/admin/newsletter-management.html
@@ -110,7 +110,7 @@
 
   </div>
 
-  <script src="/js/admin/newsletter-management.js?v=0.1.1.newsletter-delete-fix"></script>
+  <script src="/js/admin/newsletter-management.js?v=0.1.2.objectid-to-string"></script>
 
 </body>
 </html>
diff --git a/public/js/admin/newsletter-management.js b/public/js/admin/newsletter-management.js
index 456376c5..369f3fa7 100644
--- a/public/js/admin/newsletter-management.js
+++ b/public/js/admin/newsletter-management.js
@@ -147,8 +147,8 @@ function renderSubscribers(subscriptions) {
         ${formatDate(sub.subscribed_at)}
       </td>
       <td class="px-6 py-4 whitespace-nowrap text-right text-sm font-medium">
-        <button class="view-details-btn text-blue-600 hover:text-blue-900 mr-3" data-id="${sub._id}">View</button>
-        <button class="delete-subscriber-btn text-red-600 hover:text-red-900" data-id="${sub._id}" data-email="${escapeHtml(sub.email)}">Delete</button>
+        <button class="view-details-btn text-blue-600 hover:text-blue-900 mr-3" data-id="${String(sub._id)}">View</button>
+        <button class="delete-subscriber-btn text-red-600 hover:text-red-900" data-id="${String(sub._id)}" data-email="${escapeHtml(sub.email)}">Delete</button>
       </td>
     </tr>
   `).join('');